Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-203 Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com #5656

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 10, 2025

Description Of Changes

Update ethyca brand link to https://ethyca.com/

Code Changes

  • Update link in fides-js
  • Update link in privacy center
  • Added role="img" and aria-label="Ethyca" for accessibility
  • Set branded link to show in component demo page for easier testing

Steps to Confirm

  1. Go to privacy center at http://localhost:3001/ and check at the bottom that clicking Powered by takes you to https://ethyca.com/
  • If you don't see the Powered by legend you will need to update the .env file in your privacy center to have FIDES_PRIVACY_CENTER__SHOW_BRAND_LINK=true
  1. Visit the components js test page at http://localhost:3001/fides-js-components-demo.html and open the privacy settings modal to see the branded link in the bottom right corner. Check that clicking on the brand link takes you to https://ethyca.com/

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 2:48pm

Copy link

cypress bot commented Jan 10, 2025

fides    Run #11713

Run Properties:  status check passed Passed #11713  •  git commit 1fe4ff338c ℹ️: Merge 37ad75aa8d86c11cbbb4ad82d25ef31e0f06d9ea into 5557f79305b7be60ad6294b8960a...
Project fides
Branch Review refs/pull/5656/merge
Run status status check passed Passed #11713
Run duration 00m 52s
Commit git commit 1fe4ff338c ℹ️: Merge 37ad75aa8d86c11cbbb4ad82d25ef31e0f06d9ea into 5557f79305b7be60ad6294b8960a...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@lucanovera lucanovera requested a review from galvana January 10, 2025 16:03
@galvana
Copy link
Contributor

galvana commented Jan 13, 2025

Looks good 👍
image

…-Privacy-Center-powered-by-URL-to-https-ethyca.com
…s-ethyca.com' of github.com:ethyca/fides into LA-203-Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com
@lucanovera lucanovera merged commit 73188c5 into main Jan 13, 2025
20 checks passed
@lucanovera lucanovera deleted the LA-203-Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com branch January 13, 2025 15:06
Copy link

cypress bot commented Jan 13, 2025

fides    Run #11716

Run Properties:  status check failed Failed #11716  •  git commit 73188c53f9: LA-203 Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com (#5656)
Project fides
Branch Review main
Run status status check failed Failed #11716
Run duration 01m 07s
Commit git commit 73188c53f9: LA-203 Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com (#5656)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants