Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table visual fixes #5693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o

### Fixed
- Updating mongodb connectors so it can support usernames and password with URL encoded characters [#5682](https://github.com/ethyca/fides/pull/5682)
- Visual fixes for table header buttons [#5693](https://github.com/ethyca/fides/pull/5693)

## [2.53.0](https://github.com/ethyca/fides/compare/2.52.0...2.53.0)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const useDiscoveredAssetsColumns = () => {
dataTestId="select-all-rows"
/>
),
maxSize: 25,
maxSize: 40,
}),
columnHelper.accessor((row) => row.name, {
id: "name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const useDiscoveryResultColumns = ({
dataTestId="select-all-rows"
/>
),
maxSize: 25,
maxSize: 40,
}),
columnHelper.accessor((row) => row.name, {
id: "tables",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CheckIcon, Flex, ViewOffIcon } from "fidesui";
import { AntFlex as Flex, CheckIcon, ViewOffIcon } from "fidesui";

import ActionButton from "~/features/data-discovery-and-detection/ActionButton";
import {
Expand Down Expand Up @@ -31,12 +31,7 @@ const DiscoveryFieldBulkActions = ({
};

return (
<Flex
direction="row"
align="center"
justify="center"
data-testid="bulk-actions-menu"
>
<Flex data-testid="bulk-actions-menu">
<div className="flex gap-2">
<ActionButton
title="Confirm all"
Expand All @@ -45,13 +40,15 @@ const DiscoveryFieldBulkActions = ({
disabled={anyActionIsLoading}
loading={isPromoteLoading}
type="primary"
size="middle"
/>
<ActionButton
title="Ignore all"
icon={<ViewOffIcon />}
onClick={() => handleIgnoreClicked([resourceUrn])}
disabled={anyActionIsLoading}
loading={isMuteLoading}
size="middle"
/>
</div>
</Flex>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CheckIcon, Flex, Text, ViewOffIcon } from "fidesui";
import { AntFlex as Flex, CheckIcon, Text, ViewOffIcon } from "fidesui";

import ActionButton from "~/features/data-discovery-and-detection/ActionButton";
import {
Expand Down Expand Up @@ -35,19 +35,14 @@ const DiscoveryTableBulkActions = ({
}

return (
<Flex
direction="row"
align="center"
justify="center"
data-testid="bulk-actions-menu"
>
<Flex className="items-center" data-testid="bulk-actions-menu">
<Text
fontSize="xs"
fontWeight="semibold"
minW={16}
mr={6}
mr={4}
>{`${selectedUrns.length} selected`}</Text>
<div>
<Flex className="gap-2">
<ActionButton
title="Confirm"
icon={<CheckIcon />}
Expand All @@ -65,7 +60,7 @@ const DiscoveryTableBulkActions = ({
onClick={() => handleIgnoreClicked(selectedUrns)}
size="middle"
/>
</div>
</Flex>
</Flex>
);
};
Expand Down
Loading