Update from dzhibas/SublimePrettyJson@master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finding array matches only the content of the array is replaced. This content can potentially be present in multiple places and will then break later array replacements. The below example can reproduce the issue:
{
"test": [3, 4],
"test2": [1, 2, 3, 4],
"test3": [3, 4]
}
With setting "keep_arrays_single_line": true
Basically the issue occurs for two arrays A, B where A is a suffix of B and A occurs earlier in the JSON document than B.
The fix is to match the whole array, not just the content. Then remove the brackets to split and join and re-add the brackets afterwards.
If the same array occurs multiple times then this will replace all instances during the first replace, however that should not cause any issues.
The fix prevents issues with replacing arrays that are subsets of other arrays.
… Added docs about how to configure the reindent_block setting
When parse an array with config `keep_arrays_single_line = true`, `output_json.replace(m, replacement)` will replace more than once if another array is a subset of current.
Example:
```{"a": [1],"b": [2,3,1]}```
should be parsed like:
```
{
"a": [1],
"b": [2, 3, 1]
}
```
but actually got
```
{
"a": [1],
"b": [
2,
3,1]
}
```
Fix an array parse error
remove: Sublime Text 2 Support fix: JSON syntax package location for ST4 fix: empty region logic
fix: f strings
implement: .gitattributes implement: .python-verison implement: f'strings fix: libs -> lib fix: Sublime Menus
implement: #42 update: unit tests
Added: List of commands that can be mapped to shortcuts
Remove print statements
Format default settings file correctly
Features/json lines
fix array comma
ST4: format json lines
Hide sidebar in JQ window as it serves no purpose
Update Documentation of The Configuration Options
Fix check for whether jq is installed in the system
fixes #173
This commit converts `PrettyJsonLintListener` into a `ViewEventListener`, so it contains `self.view` member, required by mixed in `PrettyJsonBaseCommand` class.
... regardless how many items are in `as_json`.
fix PrettyJsonLintListener
Disable format on save by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream repository
dzhibas/SublimePrettyJson@masterhas some new changes that aren't in this fork. So, here they are, ready to be merged!This Pull Request was created programmatically by the githubpullrequests.