Update from SublimeLinter/SublimeLinter3@master #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment is outdated because the active file is always placed last in the comment. There are probably next files too but then these are "related" and we do not try to hide them.
Improve initial user settings
Introduce a new style key `annotation` which is a template string that gets interpolated using `**error`. By doing this a user can enable or disable annotations for linters, specific "codes", or types of messages.
Introduced with ae6c7f4 (Fix: Do not provide default 'types' if user set 'codes'). This is not a user visible bug because we only use keys defined in the default settings.
This reverts commit b638705.
Currently mypy expects all dicts here to be mutable which is a bug that will eventually be solved. But the *first* dict must really be mutable. So we prepare for that and wait for the "unused ignore" notice from a future mypy.
Although it is correct that `ThreadPoolExecutor` did not have a naming feature in python3.3, we manually name our threads (and rename them on their reuse) for logging purposes: we encode information in the name.
Basically we had duplicated code in `extract_lintable_regions` and `matches_selector`. Let's refactor so that we call the getters once. Deprecate `matches_selector(view, settings) -> bool`, and introduce a super-set function `match_selector(view, settings) -> regions`. Use the already introduced `LinterInfo` to pass the additional "info" around.
The root `__init__.py` is necessary for python tools like mypy but also makes reloading the package after an upgrade via Package Control fail. Ignoring the file works around this issue. Also: timbrel/GitSavvy#1943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream repository
SublimeLinter/SublimeLinter3@masterhas some new changes that aren't in this fork. So, here they are, ready to be merged!This Pull Request was created programmatically by the githubpullrequests.