Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup test framework #6

Closed
wants to merge 6 commits into from
Closed

Setup test framework #6

wants to merge 6 commits into from

Conversation

ondenman
Copy link
Contributor

@ondenman ondenman commented Apr 20, 2017 •
edited
Loading

This PR sets up the test framework in preparation of making further changes:

  • Adds scraper_test gem to run tests against .yml files.
  • Configures rake to run custom tests in addition to scraper_test task.
  • Configures travis to run tests and ensure_regression_tests.

This is a step towards scraping dates of mid-term changes: everypolitician/everypolitician-data#33101

Oliver Denman added 6 commits April 20, 2017 11:49
Add scraper_test gem
a3ce7c9
Add test helper
62ccc30
Add dummy test
1b1ea5e 
Since no other test files exist, this ensures Travis checks test_helper.
Add Rake test task
1b06458 
Runs both scraper_test and custom tests.
Configure travis to run rake
0ebfb85
Configure travis to run regression tests
026617e
@ondenman ondenman requested a review from chrismytton April 20, 2017 12:19
@tmtmtmtm
Copy link
Contributor

tmtmtmtm commented May 2, 2017

@ondenman is there anything in this PR that's still needed, or is it completely superseded by #9?

@tmtmtmtm tmtmtmtm assigned ondenman and unassigned chrismytton May 2, 2017
@ondenman
Copy link
Contributor Author

Closing as superseded by #9

@ondenman ondenman closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismytton chrismytton Awaiting requested review from chrismytton

Assignees

@ondenman ondenman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ondenman @tmtmtmtm @chrismytton