Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up rubocop for travis #4

Closed
wants to merge 9 commits into from
Closed

Set up rubocop for travis #4

wants to merge 9 commits into from

Conversation

ondenman
Copy link
Contributor

@ondenman ondenman commented Apr 24, 2017 •
edited
Loading

This PR is in preparation of refactoring the scraper to use scraped (WIP:#3 )

This enables Travis to run rubocop checks against PRs.

Note: I have not enabled Travis as the current code will not pass.

@ondenman ondenman force-pushed the set-up-rubocop-for-travis branch from 1fc5151 to 80f2bf1 Compare April 24, 2017 15:28
@ondenman ondenman requested a review from tmtmtmtm April 24, 2017 15:28
tmtmtmtm
tmtmtmtm suggested changes Apr 24, 2017
View reviewed changes
...ps---raw-githubusercontent-com-everypolitician-everypolitician-data-master--rubocop-base-yml Outdated
@@ -0,0 +1,59 @@
# A base Rubocop configuration that other repos can inherit from
# http://rubocop.readthedocs.io/en/latest/configuration/#inheriting-configuration-from-a-remote-url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you checked this in by mistake…

@tmtmtmtm tmtmtmtm assigned ondenman and unassigned tmtmtmtm Apr 24, 2017
tmtmtmtm
tmtmtmtm suggested changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@tmtmtmtm tmtmtmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

> bundle exec rake   
rake aborted!
Don't know how to build task 'rubocop' (see --tasks)

@ondenman ondenman requested a review from tmtmtmtm April 24, 2017 16:18
tmtmtmtm
tmtmtmtm suggested changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@tmtmtmtm tmtmtmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have not enabled Travis as the current code will not pass.

We shouldn't be merging code that fails bundle exec rake. This isn't about whether it fails on travis — travis is a way automating that check.

@ondenman
Copy link
Contributor Author

We shouldn't be merging code that fails bundle exec rake. This isn't about whether it fails on travis — travis is a way automating that check.

@tmtmtmtm Should I cherry pick these across to #3 then?

@tmtmtmtm
Copy link
Contributor

@ondenman I've run my semi-automatic moderniser as #5

@tmtmtmtm tmtmtmtm closed this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmtmtmtm tmtmtmtm tmtmtmtm requested changes

Assignees

@tmtmtmtm tmtmtmtm

@ondenman ondenman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondenman @tmtmtmtm