Refresh 2018-12-20 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added executive: Q15982486 Karachi Metropolitan Corporation Q2607174 Federal Cabinet of Pakistan Q28172637 Islamabad Metropolitan Corporation Q28223529 Hyderabad Municipal Corporation Q55641548 Rawalpindi Municipal Corporation Q58873610 Metropolitan Corporation Lahore Q58873612 Faisalabad Municipal Corporation Q58873615 Municipal Corporation Gujranwala Q58873622 Municipal Corporation Multan Q58873626 Quetta Metropolitan Corporation Q59240671 Municipal Corporation of Sargodha Q59240672 Municipal Corporation of Sialkot Q59240673 Municipal Corporation of Sukkar Q59240674 Municipal Corporation of Larkana Q59240678 Municipal Corporation of Dera Ghazi Khan Q59240679 Municipal Corporation of Gujrat Changes for Q59137047 - 'Provincial Cabinet of Sindh' position removed: Q28169441 Chief Minister of Sindh position added: Q3694864 Chief Minister of Sindh
jacksonj04
reviewed
Dec 20, 2018
| @@ -0,0 +1,2 @@ | |||
| Integrity checks failed: | |||
| #<struct Commons::Integrity::Check::Base::Error category=:position_id_message, message="Q132050 was found in boundaries/build/index.json but not in boundaries/build/position-data.json", filename=#<Pathname:boundaries/build/position-data.json>> | |||
There was a problem hiding this comment.
Is this just an area we lack data for?
There was a problem hiding this comment.
The boundaries index should use a specific position item ID, not just 'governor', so yeah, it needs fixing :-)
There was a problem hiding this comment.
Oh, wait. The boundary entry is for the FLACS of the FATA, which has gone, so can just be removed.
jacksonj04
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.