Do a shallow clone of everypolitician-data repo #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large proportion of the build time is currently spent cloning the everypolitician-data repo, which is now at least 1GB in size on the wire. To reduce the amount of unnecessary data that is being moved around this change switches to a shallow clone of the repo. Because we're using a shallow clone I've also had to disable the countries.json build step, because that relies on git history to work currently. We'll need to either remove the dependency on git history, or have it happen at a different stage.
tmtmtmtm
changed the base branch from
67-move-build-to-shell-script
to
master
tmtmtmtm
approved these changes
Feb 10, 2017
This was referenced Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large proportion of the build time is currently spent cloning the
everypolitician-data repo, which is now at least 1GB in size on the
wire. To reduce the amount of unnecessary data that is being moved
around this change switches to a shallow clone of the repo.
Because we're using a shallow clone I've also had to disable the
countries.json build step, because that relies on git history to work
currently. We'll need to either remove the dependency on git history, or
have it happen at a different stage.
Fixes #69
Notes to merger
Don't merge this pull request until the following have been completed:
masteronce Move build to shell script #70 has been merged.