Removing hardcoding in dbconn.py model

Reading database URI from abstract config instead of hardcoding config setting name in method; think about creating BaseModel&Metaclass instead of sharing db and using separate model for it -> coleifer/flask-peewee#103
evgeniygroznykh · Sep 23, 2020 · 701b593 · 701b593
1 parent ec974f0
commit 701b593
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/models/dbconn.py b/models/dbconn.py
@@ -1,12 +1,11 @@
 from flask import Flask
-from cfg.config import DATABASE_URI
 from sqlalchemy.exc import OperationalError as SQLAlchemyOperationalError
 from models.logger import log_db_connection_error_and_reraise
 import os
 
 class DatabaseContext:
-    def setupApplicationDatabase(app:Flask):
-        app.config['SQLALCHEMY_DATABASE_URI'] = DATABASE_URI
+    def setupApplicationDatabase(app:Flask, config):
+        app.config['SQLALCHEMY_DATABASE_URI'] = config['database-uri']
         app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
 
     def initializeDatabaseAndCreateTables(database, app:Flask):