Launch plane tickets concept exercise in beta #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a small pass through to tweak it a bit for flow and readability. This exercise is ready to be launched.
_sigh_. This all started with me re-editing the docstrings to comply with [PEP257](https://peps.python.org/pep-0257/), but then it snowballed. Turns out that [`typing.Generator`](https://docs.python.org/3/library/typing.html#typing.Generator) has been deprecated as an alias, so the tests needed some love...and that snowballed into reviewing the other docs. Also renamed the stub and test files to be in line with what we did with other concept exercises.
|
Alrighty. Here goes. Fingers crossed that folx are gonna like this one. 😅 Pushing the big, green button! |
|
Thank you so much for this! 🌟 🌈 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a pass through the plane tickets exercise, and it all looks fine to me. I tweaked a few odds and ends just for flow, but honestly this seems like a good exercise, and I think we should just turn it on.