Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Logging in with expired tokens does not work #1501

Merged

Conversation

thekevinbrown
Copy link
Member

  • Now treating users with expired tokens as guests instead of throwing
  • If this error occurs while successfully logging in, there's no need to redirect to the login, so we no longer do.
  • To achieve this, there's a new flag in context that a resolver can set to avoid the redirect to login specifically in the case of token expiry.
  • This PR also resolves information disclosure in errors in the API key authentication module, instead logging the reason for the rejection.

@thekevinbrown thekevinbrown merged commit 0bc9d0d into main Jan 8, 2025
14 checks passed
@thekevinbrown thekevinbrown deleted the fix/logging-in-with-expired-tokens-does-not-work branch January 8, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant