split deployment manifests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #82377: CSI: installation procedure for SKS. |
sauterp
changed the title
PhilippeChepy
approved these changes
Feb 9, 2024
pierre-emmanuelJ
approved these changes
Feb 9, 2024
sauterp
deleted the
philippsauter/sc-82377/split-deployment-manifests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We split the deployment manifests and make them referencable through kustomize. This simplifies the deployment for users as they don't necessarily need to clone the repo.
Checklist
(For exoscale contributors)
Testing
kubectl apply -k 'github.com/exoscale/exoscale-csi-driver/deployment?ref=philippsauter/sc-82377/split-deployment-manifests' storageclass.storage.k8s.io/exoscale-sbs created Warning: resource customresourcedefinitions/volumesnapshotclasses.snapshot.storage.k8s.io is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically. customresourcedefinition.apiextensions.k8s.io/volumesnapshotclasses.snapshot.storage.k8s.io configured Warning: resource customresourcedefinitions/volumesnapshotcontents.snapshot.storage.k8s.io is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically. customresourcedefinition.apiextensions.k8s.io/volumesnapshotcontents.snapshot.storage.k8s.io configured Warning: resource customresourcedefinitions/volumesnapshots.snapshot.storage.k8s.io is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically. customresourcedefinition.apiextensions.k8s.io/volumesnapshots.snapshot.storage.k8s.io configured serviceaccount/exoscale-csi-controller created serviceaccount/exoscale-csi-node created clusterrole.rbac.authorization.k8s.io/exoscale-csi-node-driver created clusterrole.rbac.authorization.k8s.io/exoscale-csi-attacher created clusterrole.rbac.authorization.k8s.io/exoscale-csi-provisioner created clusterrole.rbac.authorization.k8s.io/exoscale-csi-snapshotter created clusterrole.rbac.authorization.k8s.io/external-resizer created clusterrolebinding.rbac.authorization.k8s.io/csi-resizer-role created clusterrolebinding.rbac.authorization.k8s.io/exoscale-csi-attacher created clusterrolebinding.rbac.authorization.k8s.io/exoscale-csi-controller created clusterrolebinding.rbac.authorization.k8s.io/exoscale-csi-node-driver created clusterrolebinding.rbac.authorization.k8s.io/exoscale-csi-snapshotter created deployment.apps/exoscale-csi-controller created daemonset.apps/exoscale-csi-node created volumesnapshotclass.snapshot.storage.k8s.io/exoscale-snapshot created csidriver.storage.k8s.io/csi.exoscale.com created