This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
메서드 이름을 직관적으로 변경
f-lab-dev
reviewed
Dec 27, 2019
src/main/resources/delfood-8385c-firebase-adminsdk-p6vk2-9d667ced9e.json
Show resolved
Hide resolved
added 2 commits
December 27, 2019 22:48
f-lab-dev
reviewed
Dec 30, 2019
| @@ -125,6 +125,11 @@ public ItemsBillDTO getBill(HttpSession session, @RequestBody List<OrderItemDTO> | |||
| @MemberLoginCheck | |||
| public OrderDTO getOrder(HttpSession session, @PathVariable Long orderId) { | |||
| OrderDTO orderInfo = orderService.getOrder(orderId); | |||
| if (orderInfo == null) { | |||
| log.info("존재하지 않는 주문번호 조회. 주문 번호 : {}", orderId); | |||
| throw new NullPointerException("존재하지 않는 주문 정보입니다."); | |||
There was a problem hiding this comment.
주문번호 파라미터가 잘못 전달된 것이므로 IllegalArgumentException이 더 적절해보입니다
|
non-blocking 방식으로 전송하면 좋을 것 같습니다~ |
[#59] 장바구니 서비스 대상 테스트코드 작성
주소 서비스 테스트 코드 작성
Conflicts: pom.xml src/main/java/com/delfood/dto/ShopDTO.java src/main/java/com/delfood/error/ErrorController.java
- 자잘한 버그 수정
- 주문 승인 시 도착예정시간 설정 가능 - 주문 승인 시 고객에게 알림 메세지 전송
- 회원 가입 - 로그인 - 로그아웃 - 아이디와 비밀번호로 유효성 검사 - 비밀번호 변경 - 메일 변경
[#46] 주문시 쿠폰 적용
Coupon에 대한 테스트코드 작성
|
이곳은 non-blocking이 되면 리뷰하겠습니다~ (WebClient 클래스를 이용하면 쉽게 non-blocking을 사용할 수 있습니다. 하지만 non-blocking에 대해 공부해보시는것도 좋을 것 같네요) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본 설정 추가