Add support for raw tags #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raw tags add arbitrary route commands to the routing table. The current approach needs review but works. By prefixing a tag with 'fabio ' the following text will be added to the routing table. See #87
nathanejohnson
force-pushed
the
master
branch
2 times, most recently
from
a55de9d to
04f958c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw tags add arbitrary route commands to the routing
table. The current approach needs review but works.
By prefixing a tag with
fabiothe following textwill be added to the routing table.
See #87
Fixes #455
Note
Before we merge this the
servicemethod in https://github.com/fabiolb/fabio/blob/master/registry/consul/service.go#L68-L163 needs to be refactored to do only text transformations and there need to be unit tests. Also, the raw tag prefix needs to be configurable.