Skip to content

Commit

Permalink
Remove semicolon(s) from 3 files inc fboss/lib/AlertLogger.cpp
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookresearch/fbpcf#532

`-Wextra-semi` or `-Wextra-semi-stmt` found an extra semi

If the code compiles, this is safe to land.

Reviewed By: palmje, dmm-fb

Differential Revision: D53776137

fbshipit-source-id: cc37bcdc7150e3f91e0e26dbf37eae671c583179
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 18, 2024
1 parent bd041c4 commit 212bf7e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
38 changes: 19 additions & 19 deletions fboss/lib/AlertLogger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,22 @@ constexpr auto kFbossLinkSnapshotAlert("LINK_SNAPSHOT");

// Alert tag by type
AlertTag::AlertTag(std::string prefix, std::string sub_type)
: prefix_(std::move(prefix)), sub_type_(std::move(sub_type)){};
: prefix_(std::move(prefix)), sub_type_(std::move(sub_type)) {}

MiscAlert::MiscAlert() : AlertTag(kFbossAlertPrefix, kFbossMiscAlert){};
AsicAlert::AsicAlert() : AlertTag(kFbossAlertPrefix, kFbossAsicAlert){};
MiscAlert::MiscAlert() : AlertTag(kFbossAlertPrefix, kFbossMiscAlert) {}
AsicAlert::AsicAlert() : AlertTag(kFbossAlertPrefix, kFbossAsicAlert) {}
ServiceAlert::ServiceAlert()
: AlertTag(kFbossAlertPrefix, kFbossServiceAlert){};
: AlertTag(kFbossAlertPrefix, kFbossServiceAlert) {}
PlatformAlert::PlatformAlert()
: AlertTag(kFbossAlertPrefix, kFbossPlatformAlert){};
BmcAlert::BmcAlert() : AlertTag(kFbossAlertPrefix, kFbossBmcAlert){};
KernelAlert::KernelAlert() : AlertTag(kFbossAlertPrefix, kFbossKernelAlert){};
PortAlert::PortAlert() : AlertTag(kFbossAlertPrefix, kFbossPortAlert){};
RouteAlert::RouteAlert() : AlertTag(kFbossAlertPrefix, kFbossRouteAlert){};
BGPAlert::BGPAlert() : AlertTag(kBgpAlertPrefix){};
MKAAlert::MKAAlert() : AlertTag(kMkaAlertPrefix){};
: AlertTag(kFbossAlertPrefix, kFbossPlatformAlert) {}
BmcAlert::BmcAlert() : AlertTag(kFbossAlertPrefix, kFbossBmcAlert) {}
KernelAlert::KernelAlert() : AlertTag(kFbossAlertPrefix, kFbossKernelAlert) {}
PortAlert::PortAlert() : AlertTag(kFbossAlertPrefix, kFbossPortAlert) {}
RouteAlert::RouteAlert() : AlertTag(kFbossAlertPrefix, kFbossRouteAlert) {}
BGPAlert::BGPAlert() : AlertTag(kBgpAlertPrefix) {}
MKAAlert::MKAAlert() : AlertTag(kMkaAlertPrefix) {}
LinkSnapshotAlert::LinkSnapshotAlert()
: AlertTag(kLinkSnapshotAlertPrefix, kFbossLinkSnapshotAlert){};
: AlertTag(kLinkSnapshotAlertPrefix, kFbossLinkSnapshotAlert) {}

// Alert param types
constexpr auto kFbossPort("port");
Expand All @@ -59,14 +59,14 @@ constexpr auto kFbossLinkSnapshot("linkSnapshot");

// Alert parameter types
AlertParam::AlertParam(std::string type, std::string value)
: type_(std::move(type)), value_(std::move(value)){};
: type_(std::move(type)), value_(std::move(value)) {}

PortParam::PortParam(std::string value) : AlertParam(kFbossPort, value){};
VlanParam::VlanParam(std::string value) : AlertParam(kFbossVlan, value){};
Ipv4Param::Ipv4Param(std::string value) : AlertParam(kFbossIpv4Addr, value){};
Ipv6Param::Ipv6Param(std::string value) : AlertParam(kFbossIpv6Addr, value){};
MacParam::MacParam(std::string value) : AlertParam(kFbossMacAddr, value){};
PortParam::PortParam(std::string value) : AlertParam(kFbossPort, value) {}
VlanParam::VlanParam(std::string value) : AlertParam(kFbossVlan, value) {}
Ipv4Param::Ipv4Param(std::string value) : AlertParam(kFbossIpv4Addr, value) {}
Ipv6Param::Ipv6Param(std::string value) : AlertParam(kFbossIpv6Addr, value) {}
MacParam::MacParam(std::string value) : AlertParam(kFbossMacAddr, value) {}
LinkSnapshotParam::LinkSnapshotParam(std::string value)
: AlertParam(kFbossLinkSnapshot, value){};
: AlertParam(kFbossLinkSnapshot, value) {}

} // namespace facebook::fboss
2 changes: 1 addition & 1 deletion fboss/lib/HwWriteBehavior.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ class HwWriteBehaviorRAII {
private:
HwWriteBehavior prevBehavior_;
};
}; // namespace facebook::fboss
} // namespace facebook::fboss

0 comments on commit 212bf7e

Please sign in to comment.