fix: gcc uninitialized warnings triggered by unsafe_default_initialized #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
ping |
Despite all the `FOLLY_*_DISABLE_WARNING`, the implementation of `unsafe_default_initialized_cv` triggers hundreds of `-Wuninitialized` and `-Wmaybe-uninitialized` warnings when building with GCC 12, 13, 14. As much as I've tried, it seems impossible to silence the warnings purely by diagnostic pragmas. This change, however, eliminates all warnings, and the new should otherwise have the exact same effect as before. At least, I can see that clang / gcc both produce identical code before and after this change when using `unsafe_default_initialized` to initialize variables.
mhx
force-pushed
the
mhx/fix-gcc-uninit-warnings
branch
from
4d27739 to
a7be6f1
Compare
|
Updated to a version that mostly resembles the existing |
|
e11e2c2 suppresses this path under gcc. The approach in this PR could also work, but would have to be restricted to trivial types. |
|
Yes, you're correct about the restriction. I don't mind which way this is ultimately fixed, so thanks for your fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite all the
FOLLY_*_DISABLE_WARNING, the implementation ofunsafe_default_initialized_cvtriggers hundreds of-Wuninitializedand-Wmaybe-uninitializedwarnings when building with GCC 12, 13, 14. As much as I've tried, it seems impossible to silence the warnings purely by diagnostic pragmas.This change, however, eliminates all warnings, and the new code should otherwise have the exact same effect as before. At least, I can see that clang / gcc both produce identical code before and after this change when using
unsafe_default_initializedto initialize variables.