Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weak symbols trigger GCC -Waddress despite reinterpret_cast #2263

Closed
wants to merge 1 commit into from
Closed

fix: weak symbols trigger GCC -Waddress despite reinterpret_cast #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions folly/net/NetOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,12 @@ int sendmmsg(
#if defined(__EMSCRIPTEN__)
throw std::logic_error("Not implemented!");
#else
FOLLY_PUSH_WARNING
FOLLY_GCC_DISABLE_WARNING("-Waddress")
if (reinterpret_cast<void*>(::sendmmsg) != nullptr) {
return wrapSocketFunction<int>(::sendmmsg, socket, msgvec, vlen, flags);
}
FOLLY_POP_WARNING
// implement via sendmsg
for (unsigned int i = 0; i < vlen; i++) {
ssize_t ret = sendmsg(socket, &msgvec[i].msg_hdr, flags);
Expand Down
Loading