Vendor and link C++ dependencies #9581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since HHVM OSS currently only builds with libc++, we need to build all C++ dependencies from source against libc++, since their system library equivalents are built against libstdc++ on most distros and therefore ABI incompatible. Add listfiles to conditionally build gflags and glog from source accordingly if the corresponding CLANG_FORCE_LIBCPP build option is set, and update existing listfiles to correctly forward compiler options so that vendored projects are also built against libc++ if the superproject is doing so.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
|
This pull request has been merged in 91448a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HHVM OSS currently only builds with libc++, we need to build all C++ dependencies from source against libc++, since their system library equivalents are built against libstdc++ on most distros and therefore ABI incompatible.
Add listfiles to conditionally build gflags and glog from source accordingly if the corresponding CLANG_FORCE_LIBCPP build option is set, and update existing listfiles to correctly forward compiler options so that vendored projects are also built against libc++ if the superproject is doing so.
As we're here, update the fmtlib version used by the project, as v8 is too old to build with.