Skip to content

Commit

Permalink
Remove unused exception parameter from openr/decision/LinkState.cpp
Browse files Browse the repository at this point in the history
Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: xiangxu1121

Differential Revision: D52957711

fbshipit-source-id: a831a9e4e1b8a296f85e59917da8d8a797adadab
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 22, 2024
1 parent fe5f5a9 commit 411b381
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion openr/decision/LinkState.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ LinkState::removeNode(const std::string& nodeName) {
try {
CHECK(linkMap_.at(link->getOtherNodeName(nodeName)).erase(link));
CHECK(allLinks_.erase(link));
} catch (std::out_of_range const& e) {
} catch (std::out_of_range const&) {
XLOG(FATAL) << "std::out_of_range for " << nodeName;
}
}
Expand Down

0 comments on commit 411b381

Please sign in to comment.