Skip to content

Commit

Permalink
Declutter log at fullsync
Browse files Browse the repository at this point in the history
Summary:
Way too spammy at full sync as there are so many keys synced with many peers at a short period.
Hard to read and I suspected it made memory util worse as well.

Reviewed By: xiangxu1121

Differential Revision: D53682513

fbshipit-source-id: 551b4b3da7e4db7e0dcaa2d5ff438a437133c17e
  • Loading branch information
Michael Liu authored and facebook-github-bot committed Feb 13, 2024
1 parent 7aaa226 commit 842143e
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions openr/kvstore/KvStore-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -2566,12 +2566,11 @@ KvStoreDb<ClientType>::finalizeFullSync(
return;
}
params.senderId() = kvParams_.nodeId;
XLOG(INFO)
<< AreaTag()
<< fmt::format(
"[Thrift Sync] Finalize full-sync back to: {} with keys: {}",
senderId,
folly::join(",", keys));
XLOG(INFO) << AreaTag()
<< fmt::format(
"[Thrift Sync] Finalize full-sync back to: {} with {} keys",
senderId,
keys.size());

// record telemetry for thrift calls
fb303::fbData->addStatValue(
Expand Down

0 comments on commit 842143e

Please sign in to comment.