Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prop Modal.navigationBarTranslucent #4446

Merged

Conversation

alanleedev
Copy link
Contributor

@alanleedev alanleedev commented Jan 16, 2025

adding documentation on new navigationBarTranslucent prop for Modal that was added here: facebook/react-native#47254

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 933175c
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67897c8b29005300080e4d0b
😎 Deploy Preview https://deploy-preview-4446--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alanleedev alanleedev changed the title add docu on Moda.navigationBarTranslucent which was added here: https:… add prop Modal.navigationBarTranslucent Jan 16, 2025
@alanleedev alanleedev self-assigned this Jan 16, 2025
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you amend the changes to the yarn.lock file + make sure lint/build step are green?

@alanleedev alanleedev force-pushed the modal_navigationBarTranslucent branch from 382b377 to 933175c Compare January 16, 2025 21:39
@alanleedev
Copy link
Contributor Author

Can you amend the changes to the yarn.lock file + make sure lint/build step are green?

@cortinico Seems like I unintentionally included yarn.lock. Removed it and checks are green.

@cipolleschi cipolleschi merged commit 976fe81 into facebook:main Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants