Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for custom logging in native modules #4447

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

efernandes-tech
Copy link
Contributor

Added a section in the "Debugging Native Code" documentation to explain how to implement and view custom logs in native modules. This includes:

  • Android: Using the Log class and viewing logs in Logcat.
  • iOS: Using NSLog or print for Objective-C and Swift, respectively.
  • Updated the adb logcat command example to include filtering for custom module logs. These updates aim to assist developers in debugging native modules more effectively.

Added a section in the "Debugging Native Code" documentation to explain how to implement and view custom logs in native modules. This includes:
- Android: Using the `Log` class and viewing logs in Logcat.
- iOS: Using `NSLog` or `print` for Objective-C and Swift, respectively.
- Updated the `adb logcat` command example to include filtering for custom module logs.
These updates aim to assist developers in debugging native modules more effectively.
@facebook-github-bot
Copy link

Hi @efernandes-tech!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit d2fbbd0
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67918df4b258f00008fadb7c
😎 Deploy Preview https://deploy-preview-4447--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cortinico
Copy link
Contributor

I'll defer this to @huntie

In general, you can find plenty of documentation on how to print to console on Android/iOS. I don't feel we need to re-explain it on our website

@efernandes-tech
Copy link
Contributor Author

@huntie
I liked your suggestion
Thanks

@efernandes-tech
Copy link
Contributor Author

I'll defer this to @huntie

In general, you can find plenty of documentation on how to print to console on Android/iOS. I don't feel we need to re-explain it on our website

How the flipper was discontinued,
I missed this instruction on how to view the device logs in the RN app.

Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huntie huntie merged commit 70e7b2d into facebook:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants