Skip to content

Commit

Permalink
Fix flaky Mononoke Git integration test
Browse files Browse the repository at this point in the history
Summary: `test-mononoke-git-server-pull.t` when run in `dev` mode fails every now and then because the latest tag gets imported does not become available in the WBC of Mononoke Git server. This diff modifies the test to wait for the actual tag update instead of waiting for the master bookmark.

Reviewed By: gustavoavena, YousefSalama, singhsrb

Differential Revision: D67521061

fbshipit-source-id: c9b1ca322e41e5a16bab3fd6b7317441a7c91be2
  • Loading branch information
RajivTS authored and facebook-github-bot committed Dec 20, 2024
1 parent 9d604fc commit 66aa638
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@
# Pull the Git repo from Mononoke
$ cd $REPONAME
# Wait for the warm bookmark cache to catch up with the latest changes
$ wait_for_git_bookmark_move HEAD $current_head
# Wait for the warm bookmark cache to catch up with the latest changes
$ wait_for_git_bookmark_move HEAD $current_head
$ wait_for_git_bookmark_create refs/tags/last_tag
$ quiet git_client pull
# Verify that we get the same Git repo back that we started with
$ git rev-list --objects --all | git cat-file --batch-check='%(objectname) %(objecttype) %(rest)' | sort > $TESTTMP/new_object_list
Expand Down

0 comments on commit 66aa638

Please sign in to comment.