misc(container): add tests for container apps and remove build_env #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do not exercise container apps in our tests, the container app seems to be an unused fixture. This commit introduces basic tests to ensure that container apps are built and work as expected. Furthermore, this commit introduces a check that container args actually work. Finally, this commit removes the `build_env` keyword from the `ContainerImage` class. Docker has no concept of specifying environment variables at build time except by declaring build arguments. Having that keyword is messy and opens the door to non-hermetic builds, which is a recipe for leaks and reproducibility problems. Signed-off-by: squat <[email protected]>
squat
force-pushed
the
test_builing_container_apps
branch
from
5509bfd to
fbac082
Compare
efiop
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not exercise container apps in our tests, the container
app seems to be an unused fixture. This commit introduces basic tests to
ensure that container apps are built and work as expected. Furthermore,
this commit introduces a check that container args actually work.
Finally, this commit removes the
build_envkeyword from theContainerImageclass. Docker has no concept of specifying environmentvariables at build time except by declaring build arguments. Having that
keyword is messy and opens the door to non-hermetic builds, which is
a recipe for leaks and reproducibility problems.
Signed-off-by: squat [email protected]