Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run arm64 builds on arm runner #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run arm64 builds on arm runner #40

wants to merge 1 commit into from

Conversation

emgrav
Copy link
Member

@emgrav emgrav commented Aug 14, 2024 •
edited
Loading

Would allow us to do famedly/backend-build-workflows#25

@emgrav emgrav requested a review from a team as a code owner August 14, 2024 13:34
@github-actions GitHub Actions
Copy link 

* 0a94d6a32a839cbf9a93189f958ef28480f1b9ae feat: Run arm64 builds on arm runner
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* ebd46e19be1318b62adae1e722cb519949849d5f feat: add reusable workflow for OpenPGP policy regeneration
    - Trust root.

The pull request's base (ebd46e1) authenticates the pull request's head (0a94d6a).

jcgruenhage
jcgruenhage suggested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means that everything we run would now move to the expensive 16 core runners. Could we make that configurable and default to the free runners instead?

@emgrav
Copy link
Member Author

emgrav commented Aug 14, 2024 •
edited
Loading

@jcgruenhage Regrettably there is no arm-latest alias yet, afaict github plans to add this at some point this year. Would using ubuntu-latest and a named 4 or 8 core arm runner work?

@jcgruenhage
Copy link
Contributor

Sounds like a good alternative, yeah.

@emgrav emgrav force-pushed the egraven/multiarch branch from 0a94d6a to 4940138 Compare August 14, 2024 14:21
@emgrav emgrav requested a review from jcgruenhage August 14, 2024 14:21
@github-actions GitHub Actions
Copy link 

* 49401388492ed7fe3eeb13fbefacf68168e9bc64 feat: Run arm64 builds on arm runner
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* ebd46e19be1318b62adae1e722cb519949849d5f feat: add reusable workflow for OpenPGP policy regeneration
    - Trust root.

The pull request's base (ebd46e1) authenticates the pull request's head (4940138).

@github-actions GitHub Actions
Copy link 

* 7131a26131b31075f43547b813ba4eeaee291a6f feat: Allow specifying registry password
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* 49401388492ed7fe3eeb13fbefacf68168e9bc64 feat: Run arm64 builds on arm runner
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* ebd46e19be1318b62adae1e722cb519949849d5f feat: add reusable workflow for OpenPGP policy regeneration
    - Trust root.

The pull request's base (ebd46e1) authenticates the pull request's head (7131a26).

@emgrav emgrav changed the title feat: Run arm64 builds on arm runner Run arm64 builds on arm runner, add input for optionally specifying registry password Aug 15, 2024
@emgrav emgrav force-pushed the egraven/multiarch branch from 7131a26 to 52fcbb2 Compare August 15, 2024 06:08
@github-actions GitHub Actions
Copy link 

* 52fcbb2269d1602c74a884cc45a8e34581d105b5 feat: Allow specifying registry password
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* 49401388492ed7fe3eeb13fbefacf68168e9bc64 feat: Run arm64 builds on arm runner
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* ebd46e19be1318b62adae1e722cb519949849d5f feat: add reusable workflow for OpenPGP policy regeneration
    - Trust root.

The pull request's base (ebd46e1) authenticates the pull request's head (52fcbb2).

@emgrav emgrav force-pushed the egraven/multiarch branch from 52fcbb2 to 4940138 Compare August 15, 2024 06:10
@github-actions GitHub Actions
Copy link 

* 49401388492ed7fe3eeb13fbefacf68168e9bc64 feat: Run arm64 builds on arm runner
|   - Authorized by Emelie Graven <[email protected]> [89A1D21ADC4AD1D9]
* ebd46e19be1318b62adae1e722cb519949849d5f feat: add reusable workflow for OpenPGP policy regeneration
    - Trust root.

The pull request's base (ebd46e1) authenticates the pull request's head (4940138).

@emgrav emgrav changed the title Run arm64 builds on arm runner, add input for optionally specifying registry password Run arm64 builds on arm runner Aug 15, 2024
@emgrav emgrav requested a review from a team September 18, 2024 11:37
@emgrav emgrav requested review from a team and removed request for jcgruenhage and a team October 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcgruenhage jcgruenhage jcgruenhage requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emgrav @jcgruenhage