Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farcaster Connect API #1548

Closed
wants to merge 14 commits into from
Closed

Farcaster Connect API #1548

wants to merge 14 commits into from

Conversation

horsefacts
Copy link
Contributor

@horsefacts horsefacts commented Oct 27, 2023

Motivation

🚧

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

The following files were skipped due to too many changes: apps/hubble/src/rpc/test/httpServer.test.ts, packages/core/src/auth/connect.ts, packages/core/src/auth/connect.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 9651131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 10:52pm

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
siwe 2.1.4 None +6 3.09 MB w4ll3

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/eth/fidVerifier.ts 100.00% <100.00%> (ø)
apps/hubble/src/hubble.ts 53.36% <100.00%> (+0.38%) ⬆️
apps/hubble/src/rpc/httpServer.ts 94.55% <91.30%> (-0.35%) ⬇️
packages/core/src/auth/connect.ts 96.22% <96.22%> (ø)
packages/core/src/eth/clients.ts 35.71% <0.00%> (-64.29%) ⬇️

... and 10 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@horsefacts
Copy link
Contributor Author

Closing this, moving the API to a separate relay server. Cut a new branch with the verifier changes.

@horsefacts horsefacts closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant