Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase default CONCURRENCY for replicator #1550

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

sds
Copy link
Member

@sds sds commented Oct 31, 2023

Motivation

Since most users seem to connect to a remote hub, increase the default concurrency.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Added a comment explaining how to set the CONCURRENCY variable in the .env file.
  • Increased the value of the CONCURRENCY variable by multiplying it by 4 times the number of available processors.
  • Added a note about replication messages appearing out of order and the reason for it.
  • Added a note about the number of messages in the Postgres table not matching the number in the hub due to the replicator not backfilling "Remove" messages.
  • Added information about being able to query data from Postgres while the syncing process is ongoing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Since most users seem to connect to a remote hub, increase the default
concurrency.
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 9:01pm

Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: 4cb4e65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sds sds changed the title Increase default CONCURRENCY for replicator fix: Increase default CONCURRENCY for replicator Oct 31, 2023
@sds sds added the t-bug A fix for a bug with the current system label Oct 31, 2023
@sds sds merged commit e9a5aec into main Oct 31, 2023
8 checks passed
@sds sds deleted the sds/increase-default-concurrency branch October 31, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant