Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domains): support v1 functionality #1374

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jan 20, 2025

Important

This PR requires fastly/go-fastly#577 to be published in a new release.
The CI will fail until a new release is published.
Once a new release is out I'll push a commit to update the go.mod/go.sum.
Locally, I'm using go work to validate.

The implementation adds a new domain-v1 subcommand (leaving the existing domain subcommand as-is).

@Integralist Integralist force-pushed the integralist/domains-v1 branch from 875e49f to bf08193 Compare January 21, 2025 07:27
@Integralist Integralist requested a review from kpfleming January 21, 2025 12:55
@Integralist Integralist marked this pull request as ready for review January 22, 2025 13:04
@Integralist Integralist requested a review from tundal45 January 22, 2025 13:05
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants