Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix process leak #38

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix process leak #38

merged 1 commit into from
Mar 25, 2024

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Mar 24, 2024

Update webview to a recent (but not latest, as it has breaking changes and after fixing them link fails).
There should be no orphan process shown as about: in Activity Monitor and named com.apple.WebKit.WebContent in ps ax.
The effective change is to release m_webview on ~cocoa_wkwebview_engine.

@eagleoflqj eagleoflqj requested a review from ksqsf March 24, 2024 21:04
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksqsf ksqsf merged commit fddf314 into master Mar 25, 2024
3 checks passed
@ksqsf ksqsf deleted the process-leak branch March 25, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants