Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing actions #37

Merged
merged 9 commits into from
May 13, 2024
Merged

Support testing actions #37

merged 9 commits into from
May 13, 2024

Conversation

felixdivo
Copy link
Owner

Implements #25.

This is based on the great work of @vik748 in #27 (!) and some feedback from @Timple.

@felixdivo felixdivo added the enhancement New feature or request label May 12, 2024
@felixdivo felixdivo self-assigned this May 12, 2024
@felixdivo
Copy link
Owner Author

felixdivo commented May 12, 2024

@vik748 & @Timple: Does this suit your needs? Is the API helpful as-is?

If it looks good, I'd add a comment on it to the README and maybe extend a bit on the tests.

@felixdivo
Copy link
Owner Author

I can't reproduce the error in https://github.com/felixdivo/ros2-easy-test/actions/runs/9054380251/job/24874170253 locally, and it appears to be unrelated.

@felixdivo felixdivo force-pushed the support-calling-actions branch from 7786703 to 4a478b0 Compare May 12, 2024 22:20
@vik748
Copy link

vik748 commented May 13, 2024

Looks great thanks.

Copy link
Contributor

@Timple Timple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could use this!

ros2_easy_test/ros2_easy_test/env.py Outdated Show resolved Hide resolved
ros2_easy_test/ros2_easy_test/env.py Outdated Show resolved Hide resolved
ros2_easy_test/ros2_easy_test/env.py Show resolved Hide resolved
@felixdivo felixdivo merged commit b7c6e3e into main May 13, 2024
4 checks passed
@felixdivo felixdivo deleted the support-calling-actions branch May 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants