Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move F3 simulation CLI to top level cmd package #841

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

masih
Copy link
Member

@masih masih commented Jan 22, 2025

Follow the conventional pattern of keeping all CLIs in one cmd package at the root of repo.

@masih masih requested a review from Kubuxu January 22, 2025 12:38
@masih masih enabled auto-merge January 22, 2025 12:38
@masih masih self-assigned this Jan 22, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Jan 22, 2025
Follow the conventional pattern of keeping all CLIs in one `cmd` package
at the root of repo.
@masih masih force-pushed the masih/mv-f3sim-cmd branch from da4321e to e0d6bd8 Compare January 22, 2025 12:40
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.36%. Comparing base (9c11ba3) to head (e0d6bd8).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   67.39%   67.36%   -0.03%     
==========================================
  Files          84       84              
  Lines        8915     8915              
==========================================
- Hits         6008     6006       -2     
- Misses       2380     2382       +2     
  Partials      527      527              

see 6 files with indirect coverage changes

@masih masih added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit abb4f5b Jan 22, 2025
14 checks passed
@masih masih deleted the masih/mv-f3sim-cmd branch January 22, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants