Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Pinned items don't show when Files is set to stay open in the background #15410

Open
MarathonMax opened this issue May 16, 2024 · 28 comments · May be fixed by #16485
Open

Bug: Pinned items don't show when Files is set to stay open in the background #15410

MarathonMax opened this issue May 16, 2024 · 28 comments · May be fixed by #16485
Assignees

Comments

@MarathonMax
Copy link

MarathonMax commented May 16, 2024

Important

Current work around is to turn off Files settings > Advanced > Leave app running in the background then close and reopen Files. If the issue still happens try the instructions here and restart your computer.

Description

There has been 1 report on GitHub and 2 in Discord of this issue. All of them relating to the start with Windows option and closing and reopening Files fixes the issue.

Steps To Reproduce

  1. Enable Files settings > Advanced > Open Files on Windows Startup
  2. Enable Files settings > Advanced > Leave app running in the background when the window is closed
  3. Restart Windows
  4. Open Files
  5. See pinned items are missing

Requirements

  • Load pins items when Files is opened on Windows Startup

Files Version

3.4.1.0

Windows Version

10.0.22631.3593

Log File

debug.log

@Josh65-2201
Copy link
Member

Josh65-2201 commented May 16, 2024

Thanks for the report,

  • Please see if they are still shown in Windows File Explorer
  • Try clearing recent folders in Windows File Explorer settings > ... > Options > Clear and disabling show recent folders in > that same menu.
  • Do you have Files settings > Advanced > Open Files on Windows startup enabled?

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label May 16, 2024
@MarathonMax
Copy link
Author

MarathonMax commented May 16, 2024 via email

@Josh65-2201
Copy link
Member

For what step aren't you seeing the option?

Windows File Explorer options here
image

Files option here
image

@MarathonMax
Copy link
Author

MarathonMax commented May 16, 2024 via email

@Josh65-2201
Copy link
Member

Do the screenshots I send help?
Also do you have Files settings > Advanced > Open Files on Windows startup enabled?

@MarathonMax
Copy link
Author

Second screen (black with green handwritten circle): my option is set to ACTIVATED

As for clearing File Explorer history ... I do not see where that is.

@Josh65-2201
Copy link
Member

Please try closing Files from the system tray and opening from the start menu.

@MarathonMax
Copy link
Author

OK got it where to clear history. Just did it. Relaunched Files (your app) and problem is fixed. Tks.

@Josh65-2201
Copy link
Member

Josh65-2201 commented May 17, 2024

Thanks for the information do you also have the leave running in background option on in Files?

@Josh65-2201 Josh65-2201 changed the title Migrating to 3.4 erased all my Pinned folders !!! Bug: Pinned items don't show when Files is opened on Windows startup May 17, 2024
@Josh65-2201 Josh65-2201 removed the needs - additional info Needs more information from the reporter label May 17, 2024
@MarathonMax
Copy link
Author

MarathonMax commented May 17, 2024 via email

@JudeLC
Copy link

JudeLC commented May 22, 2024

Exact same issue for me.

@Josh65-2201 Josh65-2201 changed the title Bug: Pinned items don't show when Files is opened on Windows startup Bug: Pinned items don't show when Files is set to stay open in the background Jun 4, 2024
@MarathonMax
Copy link
Author

MarathonMax commented Jun 6, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Jun 11, 2024

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2024

@hishitetsu do we reload the pinned items when resuming from the background?

@hishitetsu
Copy link
Member

No, but if the app starts in the background when Windows starts, they will be loaded the first time the app is opened.

@yaira2
Copy link
Member

yaira2 commented Jun 21, 2024

I'm not sure why it's sometimes clearing the list, but would adding logic to check if they need to be reloaded make sense?

@hishitetsu
Copy link
Member

It is not being cleared, but rather it is failing to load from the beginning, I guess.

@theyv
Copy link

theyv commented Jul 28, 2024

Same issue here. Clearing recents fixed the thing for now.

@TheCiROMG
Copy link

Please try closing Files from the system tray and opening from the start menu.

Closing it from the taskbar, and opening it from startup works and shows everything correctly, if it is fixed in the taskbar or starts with the system, it does not show the pinned folders and sometimes the double view is bugged (the bug is basically that it duplicates the disks and folders).

@paulcsiki
Copy link

Also impacted by this issue and restarting the File app restores the pinned item list. I don't have the "Open at startup" setting on but I do have "Leave files running in background when closed" turned on.

@tommy-IKIIKI
Copy link

I know it is not a "fix".
but if you add a New Window, it can reload the pins without restarting the whole app.

@jamesmusik
Copy link

Pinning a new item also reloads the pins.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Aug 21, 2024
@verdaderoken
Copy link
Contributor

I know it is not a "fix".
but if you add a New Window, it can reload the pins without restarting the whole app.

This works! Hope this gets fixed

@0x5bfa
Copy link
Member

0x5bfa commented Nov 19, 2024

Working on this in #16485.

Ridiculously the refresh button also doesn't work and so, once we finished working on both this and the simplification of IStorageDevicesService, we're gonna work on making the refresh button work.

@ndekross
Copy link

I am also experiencing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready to build
Development

Successfully merging a pull request may close this issue.