-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make summarize_tensor robust to non-float dtypes #171
Merged
deltheil
merged 4 commits into
finegrain-ai:main
from
piercus:summarize-non-float-tensor
Jan 11, 2024
Merged
Make summarize_tensor robust to non-float dtypes #171
deltheil
merged 4 commits into
finegrain-ai:main
from
piercus:summarize-non-float-tensor
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limiteinductive
previously approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, important fix
Thanks for your feedback @limiteinductive. I feel it worth unit testing summarize_tensor. |
limiteinductive
suggested changes
Jan 9, 2024
piercus
added a commit
to piercus/refiners
that referenced
this pull request
Jan 10, 2024
limiteinductive
force-pushed
the
summarize-non-float-tensor
branch
from
January 10, 2024 23:04
aa232ce
to
d4cc507
Compare
limiteinductive
approved these changes
Jan 10, 2024
Thanks @piercus! |
deltheil
added a commit
that referenced
this pull request
Jan 19, 2024
Calling `tensor.float()` on a complex tensor raises a warning: UserWarning: Casting complex values to real discards the imaginary part (Triggered internally at ../aten/src/ATen/native/Copy.cpp:299.) Follow up of #171
catwell
pushed a commit
that referenced
this pull request
Jan 19, 2024
Calling `tensor.float()` on a complex tensor raises a warning: UserWarning: Casting complex values to real discards the imaginary part (Triggered internally at ../aten/src/ATen/native/Copy.cpp:299.) Follow up of #171
deltheil
added a commit
that referenced
this pull request
Jan 19, 2024
Calling `tensor.float()` on a complex tensor raises a warning: UserWarning: Casting complex values to real discards the imaginary part (Triggered internally at ../aten/src/ATen/native/Copy.cpp:299.) Follow up of #171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of summarize_tensor can raise secondary error while obfuscating the original error.
Actual
When doing some experiments, the stack was displaying a secondary error
Expected
I'm expecting to get to orignal error in the stack
Which in my case was
Expected all tensors to be on the same device, but found at least two devices, cuda:1 and cuda:0! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)
Solution
This PR implements a fix for this