display module dtype and device #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This clutters a lot the tree view. I have two ideas to improve this matter:
|
limiteinductive
suggested changes
Jan 11, 2024
piercus
added a commit
to piercus/refiners
that referenced
this pull request
Jan 11, 2024
|
This version is much more KISS and should be less verbose also. |
limiteinductive
suggested changes
Jan 11, 2024
|
Thanks for your help @limiteinductive |
limiteinductive
approved these changes
Jan 11, 2024
limiteinductive
force-pushed
the
module-log-dtype-device
branch
from
075ab1e to
cfea67c
Compare
piercus
added a commit
to piercus/refiners
that referenced
this pull request
Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the context of #165, I'm splitting the training on different GPUs.
While doing this, I faced a lot of errors like
Expected all tensors to be on the same device, but found at least two devices, cuda:1 and cuda:0!.Actual
The stack trace gives information about input tensor device allocation, but not any information about the module's device & dtype information.
Expected
Print the device and the dtype of modules in the stack trace.