Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single template #147

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Single template #147

merged 3 commits into from
Nov 22, 2023

Conversation

sshelomentsev
Copy link
Contributor

@sshelomentsev sshelomentsev commented Nov 21, 2023 •
edited
Loading

Scope of changes:

  • Use single template for various customers scenarios (minimal and CloudFront templates has removed)
  • Create CloudFront distribution (and attach Lambda@Edge function) the DistributionId isn't specified. Otherwise, behavior is the same as before (ID attaches to update infra, but customers should follow manual guide for configuring cache behavior)
  • Implicit dependencies for resources
  • Added integration paths and proxy secret parameters. AWS Secret creates automatically

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sshelomentsev sshelomentsev force-pushed the feature/rework-to-single-template branch from 6be6a83 to dc4ed4c Compare November 21, 2023 17:40
@sshelomentsev sshelomentsev requested a review from ilfa November 21, 2023 17:43
@github-actions GitHub Actions
Copy link
Contributor

This PR will create a minor release 🚀

1.4.0 (2023-11-21)

Features

  • implement single CloudFormation template (7c0198d)

Bug Fixes

@sshelomentsev sshelomentsev merged commit a3f4ae0 into feature/roll-out-as-code Nov 22, 2023
2 checks passed
@TheUnderScorer TheUnderScorer deleted the feature/rework-to-single-template branch November 23, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheUnderScorer TheUnderScorer TheUnderScorer approved these changes

@ilfa ilfa Awaiting requested review from ilfa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshelomentsev @TheUnderScorer