Add option to choose output codec #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnvoor
approved these changes
Jul 16, 2024
| let convertToProRes = (outputSize.width * outputSize.height) > (3840 * 2160) && | ||
| !(formatDescription?.videoCodecType?.isProRes ?? false) | ||
| // Through anecdotal tests anything beyond 14.5K fails to encode for anything other than ProRes | ||
| let convertToProRes = (outputSize.width * outputSize.height) > (14500 * 8156) |
There was a problem hiding this comment.
This is probably limited by the h264/hevc profile used and could be actually determined somehow, but hardcoded works fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To optionally reduce file size of outputted upscaled file this PR lets the user choose the codec (hevc, h264, or prores) via the
--codecargument. Default ishevcif not specified (happy to change this if suboptimal, but I tested a 4K -> 8K upscale that was originally h264 and outputted as hevc, and it played back without any dropped frames on my MacBook Pro M1 Pro, MacBook Air M1, and iPhone 15 Pro).Going from h264 to hevc and upscaling by 2x results in about double the file size, versus about 25x for ProRes.
To make things less complicated with this change I also made it so it doesn't try to keep ProRes codec like it did before (they can just choose that if they want), and it forces ProRes if greater than 14.5K resolution as that's when it starts instantly failing to convert for anything other than ProRes.