Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix do not set consolidate after if consolidation enabled #6

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix do not set consolidate after if consolidation enabled #6

merged 1 commit into from
Apr 15, 2024

Conversation

nadavbuc
Copy link
Contributor

@nadavbuc nadavbuc commented Apr 15, 2024 •
edited
Loading

Changes

Set consolidateAfter only when policy is whenEmpty
Fixes

NodePool.karpenter.sh "nodes-default-amd64" is invalid: spec.disruption: Invalid value: "object": consolidateAfter cannot be combined with consolidationPolicy=WhenUnderutilized

Checklist

  • README is updated with new configuration values (if applicable)
  • Changes were tested and verified locally
  • Changes are covered by Unit Tests
  • Version is bumped in Chart.yaml

@nadavbuc nadavbuc merged commit 18de5e9 into master Apr 15, 2024
4 checks passed
@nadavbuc nadavbuc deleted the fix_consolidate_after_conflict branch April 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpodobiedov nickpodobiedov nickpodobiedov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadavbuc @nickpodobiedov