Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update ad account id test severity #110

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Apr 25, 2024

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_snapchat_ads#16 (also contains merged PR fivetran/dbt_snapchat_ads#20)

This PR will result in the following new package version:

v1.7.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Adjust the severity of the account_id test in ad_reporting__account_report to warn. This is required since Snapchat can hard-delete records from the history tables, but not from the reporting tables. This ensures that accurate statistics are being reported and production pipelines aren't failing. (PR #20)

Under the Hood

  • Updated the pull request templates.
  • Included auto-releaser GitHub Actions workflow to automate future releases.

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • this PR's package to true
  • Google Ads and Facebook Ads to true (if not already)
  • All other packages to false

Detailed Validation

Please share any and all of your validation steps:

See validation notes in fivetran/dbt_snapchat_ads#24

If you had to summarize this PR in an emoji, which would it be?

🧪

@fivetran-jamie fivetran-jamie self-assigned this Apr 25, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-jamie fivetran-jamie merged commit f880560 into main Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants