Feature/cdm line item #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@fivetran-catfritz I just reviewed your code and all is looking great given the data we have available! I was able to confirm that the total_amount aggregated is matching what we see as the totals in the other tables. I believe this is providing the full picture necessary to accurately calculate all the necessary reports for our normalized billing model approach.
I am going to hold off approving this until we are able to align on the documentation and when we have any feedback from the community applied to this PR. For now, this looks great!
models/common_data_models/docs.md
Outdated
There was a problem hiding this comment.
Reminder to update docs.
Comment on lines
+17
to
+28
| -- test will fail if any rows from prod are not found in dev | ||
| (select * from prod | ||
| except distinct | ||
| select * from dev) | ||
|
|
||
| union all -- union since we only care if rows are produced | ||
|
|
||
| -- test will fail if any rows from dev are not found in prod | ||
| (select * from dev | ||
| except distinct | ||
| select * from prod) | ||
| ) |
There was a problem hiding this comment.
This is a really neat approach for this validation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
The appropriate issue has been linked, tagged, and properly assignedDetailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃