Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for serializing empty collection nodes #457

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 6, 2025

This PR adds some test cases which validate serialization results from empty collection nodes.
The bug fix itself has already been addressed in the PR #456, so the changes in the library sources are only for improvements in readability and coverage.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added this to the Release v0.4.1 milestone Jan 6, 2025
@fktn-k fktn-k self-assigned this Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit b7d69c53ecff116fd59b61f213634d5c7ac418fc.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr457.zip
ID 2391437546
URL https://github.com/fktn-k/fkYAML/actions/runs/12636963829/artifacts/2391437546

@fktn-k fktn-k merged commit 71fa437 into develop Jan 6, 2025
163 checks passed
@fktn-k fktn-k deleted the add_test_cases_for_454 branch January 6, 2025 17:30
@fktn-k
Copy link
Owner Author

fktn-k commented Jan 7, 2025

See also: #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant