Fix golangci-lint errors

.github/workflows/ci.yml

@@ -18,12 +18,12 @@ jobs:
         run: go test -race -coverpkg=./... ./... -coverprofile cover.out.tmp -covermode=atomic
       - name: Removes mocks from tests
         run: cat cover.out.tmp | grep -v "_mock.go" > cover.out
-      # - name: golangci-lint
-      #   uses: golangci/golangci-lint-action@v2
-      #   with:
-      #     # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-      #     version: v1.48
-      #     args: --skip-files .*_test.go
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
+          version: v1.48
+          args: --skip-files .*_test.go
       - uses: codecov/codecov-action@v2
         with:
           file: ./cover.out

pkg/connectors/environment_loaders/cdn.go

@@ -2,7 +2,7 @@ package environment_loaders
 
 import (
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"sync"
 	"time"
@@ -116,7 +116,7 @@ func (l *CDNLoader) fetchEnvironment(envID string, APIKey string) error {
 		return nil
 	}
 
-	response, err := ioutil.ReadAll(resp.Body)
+	response, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return fmt.Errorf("error when reading body: %v", err)
 	}

pkg/connectors/hits_processors/datacollect_test.go

@@ -2,7 +2,7 @@ package hits_processors
 
 import (
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"net/http/httptest"
 	"sync"
@@ -36,7 +36,7 @@ func TestDataCollectTrack(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
 		// Send response to be tested
 		lock.Lock()
-		lastBodySent, _ := ioutil.ReadAll(req.Body)
+		lastBodySent, _ := io.ReadAll(req.Body)
 		bodySents = append(bodySents, string(lastBodySent))
 		_, err := rw.Write([]byte("{}"))
 		assert.Nil(t, err)

pkg/handlers/activate_test.go

@@ -2,7 +2,6 @@ package handlers
 
 import (
 	"io"
-	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -33,7 +32,7 @@ func TestActivate(t *testing.T) {
 	Activate(context)(w, req)
 
 	resp := w.Result()
-	bodyResp, _ := ioutil.ReadAll(resp.Body)
+	bodyResp, _ := io.ReadAll(resp.Body)
 	assert.Equal(t, 400, resp.StatusCode)
 	assert.Contains(t, string(bodyResp), "unknown field")
 
@@ -50,7 +49,7 @@ func TestActivate(t *testing.T) {
 	Activate(context)(w, req)
 
 	resp = w.Result()
-	bodyResp, _ = ioutil.ReadAll(resp.Body)
+	bodyResp, _ = io.ReadAll(resp.Body)
 	assert.Equal(t, 400, resp.StatusCode)
 	assert.Contains(t, string(bodyResp), "Field is mandatory")
 

pkg/handlers/campaign_test.go

@@ -93,7 +93,7 @@ func TestSendSingleFormatResponse(t *testing.T) {
 	resp := w.Result()
 	assert.Equal(t, 200, resp.StatusCode)
 	assert.Equal(t, "application/json", resp.Header.Get("Content-Type"))
-	body, _ := ioutil.ReadAll(resp.Body)
+	body, _ := io.ReadAll(resp.Body)
 	assert.Contains(t, string(body), `"variation":`)
 
 	// other modification type returns json format
@@ -104,7 +104,7 @@ func TestSendSingleFormatResponse(t *testing.T) {
 	resp = w.Result()
 	assert.Equal(t, 200, resp.StatusCode)
 	assert.Equal(t, "application/json", resp.Header.Get("Content-Type"))
-	body, _ = ioutil.ReadAll(resp.Body)
+	body, _ = io.ReadAll(resp.Body)
 	assert.Contains(t, string(body), `"variation":`)
 
 	// html type with single fields returns text/html with html value
@@ -117,7 +117,7 @@ func TestSendSingleFormatResponse(t *testing.T) {
 	assert.Equal(t, 200, resp.StatusCode)
 	assert.Equal(t, "text/html", resp.Header.Get("Content-Type"))
 
-	body, _ = ioutil.ReadAll(resp.Body)
+	body, _ = io.ReadAll(resp.Body)
 	assert.Equal(t, "value", string(body))
 
 	// text type with single fields returns text/plain withs stringified bool value
@@ -130,7 +130,7 @@ func TestSendSingleFormatResponse(t *testing.T) {
 	assert.Equal(t, 200, resp.StatusCode)
 	assert.Equal(t, "text/plain", resp.Header.Get("Content-Type"))
 
-	body, _ = ioutil.ReadAll(resp.Body)
+	body, _ = io.ReadAll(resp.Body)
 	assert.Equal(t, "true", string(body))
 
 	// text type with single fields returns text/plain withs stringified number value
@@ -139,6 +139,6 @@ func TestSendSingleFormatResponse(t *testing.T) {
 	sendSingleFormatResponse(w, campaign, logger.New("debug", "test"))
 
 	resp = w.Result()
-	body, _ = ioutil.ReadAll(resp.Body)
+	body, _ = io.ReadAll(resp.Body)
 	assert.Equal(t, "20.5", string(body))
 }