Skip to content

Commit

Permalink
Merge pull request #39 from flagship-io/ci/update-docker-build-action
Browse files Browse the repository at this point in the history
ci(actions): update docker login creds to use the GITHUB_TOKEN associated with the actions job
  • Loading branch information
alex-binet authored Nov 14, 2024
2 parents 7261159 + 2fbdf36 commit 4827282
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GHCR_TOKEN }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Set output
id: vars
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.23.3-alpine as builder
FROM golang:1.23.3-alpine AS builder
RUN apk add --update make
WORKDIR /go/src/github/flagship-io/decision-api

Expand All @@ -10,11 +10,11 @@ RUN go mod download
COPY . .

ARG VERSION
ENV VERSION $VERSION
ENV VERSION=$VERSION
RUN make build

FROM alpine:latest
RUN apk --no-cache add ca-certificates
WORKDIR /root/
COPY --from=builder /go/src/github/flagship-io/decision-api/bin/server ./
CMD ["./server"]
CMD ["./server"]

0 comments on commit 4827282

Please sign in to comment.