Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decision group on empty standard assignments #44

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

guillaumejacquart
Copy link
Contributor

Fix decision group assignments override that did not work if the visitor did not have any assignments in cache yet.
Fix and improve unit tests

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d7130ad) 82.12% compared to head (dd5dbd9) 82.40%.

Files Patch % Lines
decision.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   82.12%   82.40%   +0.27%     
==========================================
  Files           9        9              
  Lines         621      625       +4     
==========================================
+ Hits          510      515       +5     
+ Misses         83       82       -1     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejacquart guillaumejacquart merged commit aa8abef into main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants