feat(docs): reshape agent bot notifications guide to make it generic #524
+62
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuco23
reviewed
Jan 20, 2025
|
|
||
| ```json | ||
| { | ||
| "apiKey": "API_KEY", |
There was a problem hiding this comment.
can we have "apiUrl" as the first object property, and switch out the appropriate parts in the explanation?
| }; | ||
| ``` | ||
|
|
||
| ## Telegram Notifications Alert Configuration |
There was a problem hiding this comment.
can we title this ## Flare-Hosted Telegram Notifications Alert Configuration
| ``` | ||
|
|
||
| Notifications will only be sent out for `danger` and `critical` levels, regardless of the configured level. | ||
| This is enforced by the Telegram bot, which ignores other events to prevent unnecessary HTTP requests. |
There was a problem hiding this comment.
"unnecessary HTTP requests" -> "priority message delivery issues due to heavy load"
|
@nejc-flare-network please take another look |
kuco23
reviewed
Jan 20, 2025
| { | ||
| "apiUrl": "NOTIFICATIONS_API_URL", | ||
| "apiKey": "API_KEY", | ||
|
|
|
|
||
| ```json | ||
| { | ||
| "apiKey": "API_KEY", |
There was a problem hiding this comment.
nitpicking, but can you switch out those two also :)
dineshpinto
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.