Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

Picture #5

Closed
wants to merge 2 commits into from
Closed

Picture #5

wants to merge 2 commits into from

Conversation

frelei
Copy link
Contributor

@frelei frelei commented Dec 15, 2016

I just add the facebook image id returning when the user selected the image as well. It's good because we can work with the image id instead of the image itself.

Once I just add a small modification I am create this PR to the master. If it's necessary I can create a PR to development.

@floriangbh
Copy link
Owner

floriangbh commented Dec 15, 2016

Hello @frelei !

Thank you for this PR ! :-)
Can you create this PR in development branche please ? It will be more easy for me and the next release !

I think this is more powerful if the didSelectImage return image model which contain id, url or image. It will be more easy if we need more informations about the image in the futur evolution. What do you think about it ? :)

Tomorrow I will push the v1.0.13 to cocoapods with the id (in image model) in the didSelectImage :-)

@frelei
Copy link
Contributor Author

frelei commented Dec 15, 2016

Hello @terflogag,

Thanks for the quickly answer.
I will create the PR in the development branch, no problems.

I agree with you, it's better return the image model, however I think it's good send the as well the UIImage.

So I will do those modification and open a new PR.

Thanks

@frelei frelei closed this Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants