Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Format the sessions dates with the correct locale #657

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix: Format the sessions dates with the correct locale #657

merged 2 commits into from
Mar 25, 2024

Conversation

marienfressinaud
Copy link
Member

@marienfressinaud marienfressinaud commented Mar 25, 2024 •
edited
Loading

Pull request checklist:

  • code is manually tested
  • interface works on both mobiles and big screens
  • accessibility has been tested
  • tests are updated
  • French locale is synchronized
  • documentation is updated (including comments, commit messages, migration notes, …)

If you think one of the item isn’t applicable to the PR, please check it
anyway and precise N/A next to it.

@marienfressinaud
fix: Format the sessions dates with the correct locale
63609b1 
`_d()` is the function provided by Minz, but it considers the locale
of the server, not the one of the current user.

`_date()` is the correct function to use in flusio.
@marienfressinaud
dev: Refactor the _date helper function
28620cb
@marienfressinaud marienfressinaud merged commit 28620cb into main Mar 25, 2024
2 checks passed
@marienfressinaud marienfressinaud deleted the fix/session-date branch March 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marienfressinaud