[webview_flutter_wkwebview] Add a listener for the canGoBack property change on the iOS platform. #8203
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Hi @StanleyCocos thanks for your patch. I looks like this change is causing existing tests to fail and does not include any new test code. Once you've fixed both those issues, please let me know and I'll take a look! |
|
@cbracken I’ve added a test case and fixed the integration test error. However, there seems to be another issue caused by not updating the version. I'm not sure what I should do to fix this. Could you give me some advice? |
|
can you review again cc @cbracken |
|
One last fix to make to get CI passing: |
|
I seem to understand that the version information needs to be adjusted. But I don't know how to make the changes. Or should I apply for the "no version control required" tag? |
This comment was marked as resolved.
This comment was marked as resolved.
|
can you review again |
cbracken
approved these changes
Jan 7, 2025
stuartmorgan
requested review from
bparrishMines
and removed request for
stuartmorgan
|
@bparrishMines would be a better second reviewer here. |
bparrishMines
changed the title
bparrishMines
approved these changes
Jan 9, 2025
bparrishMines
added
the
autosubmit
berhili098
added a commit
to berhili098/packages
that referenced
this pull request
Jan 9, 2025
… change on the iOS platform. (flutter#8203) Added a listener callback for the canGoBack property on iOS. Since it can only be effectively implemented on iOS, it is only exposed in the WKWebView layer. Fixes flutter/flutter#158160 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] page, which explains my responsibilities. - [ ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [ ] I [linked to at least one issue that this PR fixes] in the description above. - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2025
…k property change on the iOS platform. (flutter/packages#8203)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2025
flutter/packages@3fc6b7a...6554751 2025-01-09 [email protected] [webview_flutter_wkwebview] Add a listener for the canGoBack property change on the iOS platform. (flutter/packages#8203) 2025-01-09 [email protected] [flutter_svg] Implement errorBuilder callback (flutter/packages#8364) 2025-01-08 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdDisplayContainer`. (flutter/packages#8153) 2025-01-08 [email protected] [go_router_builder] Add a fallback for a not null List or Set param (flutter/packages#8349) 2025-01-08 [email protected] Manual roll Flutter (stable) from 8495dee to 17025dd (2 revisions) (flutter/packages#8396) 2025-01-08 [email protected] [ci][video_player_android][camera_android_camerax] Manual roll and fix tests (flutter/packages#8391) 2025-01-07 [email protected] [ci] Run web tests in wasm (unit + integration). (flutter/packages#8111) 2025-01-07 [email protected] [camera_platform_interface] Add API support query for image streaming (flutter/packages#8307) 2025-01-07 [email protected] [camera_android_camerax][video_player_android] Suppresses deprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388) 2025-01-07 [email protected] Bump Remaining Plugin Example Apps to targetSdkVersion >= 34 and compileSdkVersion >= 34 (flutter/packages#8361) 2025-01-07 [email protected] Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter/packages#8384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a listener callback for the canGoBack property on iOS. Since it can only be effectively implemented on iOS, it is only exposed in the WKWebView layer.
Fixes flutter/flutter#158160
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).