fix: call super.dispose after disposing local resources

flyerhq · Dec 30, 2024 · f811437 · f811437
1 parent 2cd362c
commit f811437
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/examples/flyer_chat/lib/gemini.dart b/examples/flyer_chat/lib/gemini.dart
@@ -55,10 +55,10 @@ class GeminiState extends State<Gemini> {
 
   @override
   void dispose() {
-    super.dispose();
     _chatController.dispose();
     _scrollController.dispose();
     _crossCache.dispose();
+    super.dispose();
   }
 
   @override

diff --git a/examples/flyer_chat/lib/local.dart b/examples/flyer_chat/lib/local.dart
@@ -28,8 +28,8 @@ class LocalState extends State<Local> {
 
   @override
   void dispose() {
-    super.dispose();
     _chatController.dispose();
+    super.dispose();
   }
 
   @override

diff --git a/examples/flyer_chat/lib/main.dart b/examples/flyer_chat/lib/main.dart
@@ -64,8 +64,8 @@ class _FlyerChatHomePageState extends State<FlyerChatHomePage> {
 
   @override
   void dispose() {
-    super.dispose();
     _dio.close(force: true);
+    super.dispose();
   }
 
   @override

diff --git a/packages/flutter_chat_ui/lib/src/chat.dart b/packages/flutter_chat_ui/lib/src/chat.dart
@@ -81,17 +81,17 @@ class _ChatState extends State<Chat> with WidgetsBindingObserver {
 
   @override
   void dispose() {
-    super.dispose();
     WidgetsBinding.instance.removeObserver(this);
     // Only try to dispose cross cache if it's not provided, since
     // users might want to keep downloading media even after the chat
     // is disposed.
-    if (widget.crossCache == null) {
-      _crossCache.dispose();
-    }
     if (widget.scrollController == null) {
       _scrollController.dispose();
     }
+    if (widget.crossCache == null) {
+      _crossCache.dispose();
+    }
+    super.dispose();
   }
 
   @override

diff --git a/packages/flutter_chat_ui/lib/src/chat_animated_list/chat_animated_list.dart b/packages/flutter_chat_ui/lib/src/chat_animated_list/chat_animated_list.dart
@@ -162,10 +162,10 @@ class ChatAnimatedListState extends State<ChatAnimatedList>
 
   @override
   void dispose() {
-    super.dispose();
     _scrollToBottomShowTimer?.cancel();
     _scrollToBottomController.dispose();
     _operationsSubscription.cancel();
+    super.dispose();
   }
 
   @override

diff --git a/packages/flutter_chat_ui/lib/src/chat_animated_list/chat_animated_list_reversed.dart b/packages/flutter_chat_ui/lib/src/chat_animated_list/chat_animated_list_reversed.dart
@@ -111,8 +111,8 @@ class ChatAnimatedListReversedState extends State<ChatAnimatedListReversed> {
 
   @override
   void dispose() {
-    super.dispose();
     _operationsSubscription.cancel();
+    super.dispose();
   }
 
   @override

diff --git a/packages/flutter_chat_ui/lib/src/chat_message/chat_message_internal.dart b/packages/flutter_chat_ui/lib/src/chat_message/chat_message_internal.dart
@@ -63,8 +63,8 @@ class ChatMessageInternalState extends State<ChatMessageInternal> {
 
   @override
   void dispose() {
-    super.dispose();
     _operationsSubscription?.cancel();
+    super.dispose();
   }
 
   @override