-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Flyteadmin] Add variablemap in dataproxy for dataclass/pydantic #6136
Draft
mao3267
wants to merge
4
commits into
flyteorg:master
Choose a base branch
from
mao3267:add-dataproxy-dataclass-variablemap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP][Flyteadmin] Add variablemap in dataproxy for dataclass/pydantic #6136
mao3267
wants to merge
4
commits into
flyteorg:master
from
mao3267:add-dataproxy-dataclass-variablemap
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mao3267 <[email protected]>
Signed-off-by: mao3267 <[email protected]>
Code Review Agent Run Status
|
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6136 +/- ##
==========================================
- Coverage 37.06% 37.05% -0.02%
==========================================
Files 1318 1319 +1
Lines 132638 132763 +125
==========================================
+ Hits 49157 49190 +33
- Misses 79231 79321 +90
- Partials 4250 4252 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mao3267 <[email protected]>
…taproxy-dataclass-variablemap
Code Review Agent Run Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Problem
There are two main components to manage when retrieving the
variable_map
in the Dataproxy'sGetData
function:GetDataFromNodeExecution
andGetDataFromTaskExecution
. Since thevariable_map
resides in theTaskClosure
, it is logical to retrieve it from the Task Repository using the Task's identification details (ID, project, domain, and version).However, I am unable to determine how to access the output from node execution. Is there a way to retrieve the
TaskClosure
(orTask
) directly from theNodeExecution
?Tracking issue
#6081
Why are the changes needed?
While the task input/output is represented as a dataclass or Pydantic model, using the get function to fetch the FlyteRemote execution output will fail due to the absence of the variable_map information. To address this issue, we aim to provide the input/output variable_map through the Dataproxy as a solution.
What changes were proposed in this pull request?
GetData
from dataproxy service.How was this patch tested?
TODO
Setup process
Screenshots
TODO
Check all the applicable boxes
Related PRs
flyteorg/flytekit#3031
Docs link
TODO