Skip to content

Commit

Permalink
75 upgrade bakta to 151+ (#76)
Browse files Browse the repository at this point in the history
* updating BAKTA docker image tag

* make the version tags of additional non-core tools (bakta, flye and unicycler) a parameter that can be configured

* update json schema with new parameters

* update docs and version number

* fix indentation

* update bakta version to latest before release
  • Loading branch information
fmalmeida authored Dec 7, 2022
1 parent edd9377 commit fe1c085
Show file tree
Hide file tree
Showing 8 changed files with 61 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"description": "<p>The pipeline</p>\n\n<p>bacannot, is a customisable, easy to use, pipeline that uses state-of-the-art software for comprehensively annotating prokaryotic genomes having only Docker and Nextflow as dependencies. It is able to annotate and detect virulence and resistance genes, plasmids, secondary metabolites, genomic islands, prophages, ICEs, KO, and more, while providing nice an beautiful interactive documents for results exploration.</p>",
"license": "other-open",
"title": "fmalmeida/bacannot: A generic but comprehensive bacterial annotation pipeline",
"version": "v3.1.6",
"version": "v3.1.7",
"upload_type": "software",
"creators": [
{
Expand Down
7 changes: 7 additions & 0 deletions conf/defaults.config
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,13 @@ params {
// User's custom database coverage threshold
blast_custom_mincov = 65

// Select versions of bioconda quay.io additional tools
// Tools that are not part of the core of the pipeline,
// but can eventually be used by users
unicycler_version = '0.4.8--py38h8162308_3'
flye_version = '2.9--py39h39abbe0_0'
bakta_version = '1.6.1--pyhdfd78af_0'

// Max resource options
// Defaults only, expecting to be overwritten
max_memory = '20.GB'
Expand Down
6 changes: 3 additions & 3 deletions conf/docker.config
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ process {
}

withName: UNICYCLER {
container = 'quay.io/biocontainers/unicycler:0.4.8--py38h8162308_3'
container = "quay.io/biocontainers/unicycler:${params.unicycler_version}"
}

withName: FLYE {
container = 'quay.io/biocontainers/flye:2.9--py39h39abbe0_0'
container = "quay.io/biocontainers/flye:${params.flye_version}"
}

withName: BAKTA {
container = 'quay.io/biocontainers/bakta:1.5.0--pyhdfd78af_0'
container = "quay.io/biocontainers/bakta:${params.bakta_version}"
}

/*
Expand Down
8 changes: 6 additions & 2 deletions conf/singularity.config
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,15 @@ process {
}

withName: UNICYCLER {
container = 'https://depot.galaxyproject.org/singularity/unicycler:0.4.8--py38h8162308_3'
container = "https://depot.galaxyproject.org/singularity/unicycler:${params.unicycler_version}"
}

withName: FLYE {
container = 'https://depot.galaxyproject.org/singularity/flye:2.9--py39h39abbe0_0'
container = "https://depot.galaxyproject.org/singularity/flye:${params.flye_version}"
}

withName: BAKTA {
container = "https://depot.galaxyproject.org/singularity/bakta:${params.bakta_version}"
}

/*
Expand Down
10 changes: 10 additions & 0 deletions docs/manual.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,16 @@ Users can give fasta files (nucl or prot) properly formatted or a text file cont
| :--------------------------------------- | :------- | :------ | :---------- |
| `--bedtools_merge_distance` | :material-close: | NA | Minimum number of required overlapping bases to merge genes. By default it is not executed. |

## Non-core tools versions

Users can now select the version of the non-core tools Bakta, Unicyler and Flye. These tools now have a parameter which controls which tag, thus version, from quay.io to use.

| Parameter | Default | Description |
| :-------- | :------ | :---------- |
| `--bakta_version` | 1.6.1--pyhdfd78af_0 | Bakta tool version |
| `--flye_version` | 2.9--py39h39abbe0_0 | Flye tool version |
| `--unicycler_version` | 0.4.8--py38h8162308_3 | Unicycler tool version |

## Max job request options

Set the top limit for requested resources for any single job. If you are running on a smaller system, a pipeline step requesting more resources than are available may cause the Nextflow to stop the run with an error. These options allow you to cap the maximum resources requested by any single job so that the pipeline will run on your system.
Expand Down
9 changes: 8 additions & 1 deletion markdown/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@

The tracking for changes started in v2.1

## v3.1.7 [6-December-2022]

* Fixes https://github.com/fmalmeida/bacannot/issues/75 reported by @sunitj, who highlighted that bakta tool required an update.
* Now, as a consequence, the non-core tools, namely Bakta, Flye and Unicycler that are used only when required in particular cases now have a parameter to control the version of the tool desired.
* These non-default tools are used with bioconda images from quay.io, now they have parameters `--bakta_version`, `--unicycler_version` and `--flye_version` that allows users to control the version (from quay.io) used.
* PR: https://github.com/fmalmeida/bacannot/pull/76

## v3.1.6 [7-November-2022]

* Fixes https://github.com/fmalmeida/bacannot/issues/71 reported by @fetyj, which highlights that antismash module was failing when outputs for a sample were empty.
* Fixes https://github.com/fmalmeida/bacannot/issues/71 reported by @fetyj, who highlights that antismash module was failing when outputs for a sample were empty.
- To solve this issue, the module was updated as such the antismash main results is now optional instead of being required, and 'gff conversion' steps are done only when it's results are not empty.
- PR: https://github.com/fmalmeida/bacannot/pull/72

Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ manifest {
homePage = "https://github.com/fmalmeida/bacannot"
mainScript = "main.nf"
nextflowVersion = ">=20.10.0"
version = '3.1.6'
version = '3.1.7'
}

// Function to ensure that resource requirements don't go beyond
Expand Down
35 changes: 25 additions & 10 deletions nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
"plasmids_minid": {
"type": "number",
"description": "Identity threshold for plasmid annotation",
"default": 90,
"default": 90.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -183,7 +183,7 @@
"plasmids_mincov": {
"type": "number",
"description": "overage threshold for plasmid annotation",
"default": 60,
"default": 60.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -192,7 +192,7 @@
"blast_virulence_minid": {
"type": "number",
"description": "Identity threshold for virulence factors annotation",
"default": 90,
"default": 90.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -201,7 +201,7 @@
"blast_virulence_mincov": {
"type": "number",
"description": "overage threshold for virulence factors annotation",
"default": 90,
"default": 90.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -210,7 +210,7 @@
"blast_resistance_minid": {
"type": "number",
"description": "Identity threshold for resistance genes annotation",
"default": 90,
"default": 90.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -219,7 +219,7 @@
"blast_resistance_mincov": {
"type": "number",
"description": "overage threshold for resistance genes annotation",
"default": 90,
"default": 90.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -228,7 +228,7 @@
"blast_MGEs_minid": {
"type": "number",
"description": "Identity threshold for ICEs and prophages annotation",
"default": 85,
"default": 85.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand All @@ -237,7 +237,7 @@
"blast_MGEs_mincov": {
"type": "number",
"description": "overage threshold for ICEs and prophages annotation",
"default": 85,
"default": 85.0,
"minimum": 0,
"maximum": 100,
"help_text": "Must be between 0 and 100",
Expand Down Expand Up @@ -267,15 +267,15 @@
"blast_custom_minid": {
"type": "number",
"description": "Min. identity % for the annotation using user's custom database",
"default": 65,
"default": 65.0,
"minimum": 0,
"maximum": 100,
"hidden": true
},
"blast_custom_mincov": {
"type": "number",
"description": "Min. gene/subject coverage % for the annotation using user's custom database",
"default": 65,
"default": 65.0,
"minimum": 0,
"maximum": 100,
"hidden": true
Expand Down Expand Up @@ -329,6 +329,21 @@
"description": "Show all params when using `--help`",
"hidden": true,
"help_text": "By default, parameters set as _hidden_ in the schema are not shown on the command line when a user runs with `--help`. Specifying this option will tell the pipeline to show all parameters."
},
"unicycler_version": {
"type": "string",
"description": "Select quay.io image tag for tool",
"default": "0.4.8--py38h8162308_3"
},
"flye_version": {
"type": "string",
"description": "Select quay.io image tag for tool",
"default": "2.9--py39h39abbe0_0"
},
"bakta_version": {
"type": "string",
"description": "Select quay.io image tag for tool",
"default": "1.6.1--pyhdfd78af_0"
}
}
},
Expand Down

0 comments on commit fe1c085

Please sign in to comment.